Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEUS-4449] Improve documentation around the user-agent issue #16

Conversation

artem-y-pamediagroup
Copy link
Contributor

@artem-y-pamediagroup artem-y-pamediagroup commented Jun 10, 2024

Jira

Changes

  • updated the README section about playing free and non-free videos in an attempt to describe more cases and make things more explicit
  • dedicated a whole subsection to configuring the user-agent header to make clearer and also make it stand out more
  • updated existing Swift docs on the Getting Started page: moved the step describing errors into the docs, fixed grammar and a few typos, re-generated the docs
  • cleaned up the Swift docs: removed placeholder comments with author and date from the code examples, removed redundant duplication of step names (Step 1: because it says Step 1 right above etc.)
  • added an optional Step 2 about the user-agent header as an incremental step, which means you can see difference in the implementation compared to the previous step.

@artem-y-pamediagroup artem-y-pamediagroup merged commit 5125186 into release/1.0.3 Jun 11, 2024
9 checks passed
@artem-y-pamediagroup artem-y-pamediagroup deleted the feature/ZEUS-4449-update-docs-on-user-agent-issue branch July 3, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants