Hotfix 1.0.2: Revert to an old way of connecting the exact player version dependency #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-y-pamediagroup
requested review from
zachtom,
StefanoStream and
KharchenkoAlex
StefanoStream
approved these changes
May 17, 2024
KharchenkoAlex
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Changes
We are getting a deprecation warning in Package.swift, so in the previous PR I tried switching the dependency to a new "revision" way of connecting the player dependency. This worked fine when connecting the package locally.
However, when pulling in another project, it resulted in an error while trying to pull the correct player version. That's why for now I'm reverting this part to the way it was working before, at least until we decide to update the version of Bitmovin player.