[ZEUS-4778] Prevent crash caused by double unbinding of background service #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-y-pamediagroup
requested review from
zachtom,
saberouechtati,
StefanoStream and
oleksiiSazhko-pamedia
zachtom
approved these changes
Aug 14, 2024
...-sdk-android/src/main/java/com/streamamg/player/plugin/bitmovin/BitmovinVideoPlayerPlugin.kt
Outdated
Show resolved
Hide resolved
...-sdk-android/src/main/java/com/streamamg/player/plugin/bitmovin/BitmovinVideoPlayerPlugin.kt
Outdated
Show resolved
Hide resolved
saberouechtati
approved these changes
Aug 14, 2024
saberouechtati
approved these changes
Aug 14, 2024
StefanoStream
approved these changes
Aug 15, 2024
artem-y-pamediagroup
deleted the
bugfix/ZEUS-4778-prevent-crash-when-closing-player
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Changes
backgroundService(start:)method into two different methods with more meaningful names so it's easier to reason about what's going onConcerns
This is quick fix to patch the crash, which might be a symptom of a larger issue we have related to management of player and other related objects.