feat: remove tracing

We don't need very advanced logging and instrumentation.

BREAKING CHANGE: Remove feature "tracing" from mp4-stream crate

Cargo.toml

@@ -20,10 +20,8 @@ hyper = "0.14"
 tokio = { version = "1.30", features = ["rt", "macros", "fs", "io-util"] }
 futures-lite = "1.13"
 flume = "0.10"
-tracing = "0.1"
-tracing-subscriber = { version = "0.3", features = ["env-filter"] }
-tracing-tree = "0.2"
-tracing-error = "0.2"
+log = "0.4"
+env_logger = "0.10"
 include_dir = "0.7"
 xflags = "0.3"
 confy = "0.5"
@@ -37,7 +35,7 @@ tower-cookies = "0.9"
 ring = "0.16"
 jsonwebtoken = "8.3"
 rust-argon2 = "1.0"
-mp4-stream = { path = "crates/mp4-stream", features = ["serde", "tracing"] }
+mp4-stream = { path = "crates/mp4-stream", features = ["serde", "log"] }
 quick-error = "2.0"
 serde = { version = "1.0", features = ["derive"] }
 chrono = "0.4"

crates/mp4-stream/Cargo.toml

@@ -16,8 +16,8 @@ license.workspace = true
 [dependencies]
 flume.workspace = true
 quick-error.workspace = true
-tracing = { workspace = true, optional = true }
 serde = { workspace = true, optional = true }
+log = { workspace = true, optional = true }
 chrono.workspace = true
 bitflags.workspace = true
 fixed.workspace = true

crates/mp4-stream/src/capabilities.rs

@@ -119,7 +119,6 @@ struct Resolution {
 ///
 /// This function may return a [`Error::Io`] if interaction with the filesystem
 /// fails or a [`Error::Camera`] if the camera returns an error.
-#[cfg_attr(feature = "tracing", tracing::instrument(level = "debug"))]
 pub fn get_capabilities_all() -> crate::Result<Capabilities> {
     let mut caps = HashMap::new();
 
@@ -147,7 +146,6 @@ pub fn get_capabilities_all() -> crate::Result<Capabilities> {
 ///
 /// This function may return a [`Error::Io`] if interaction with the filesystem
 /// fails or a [`Error::Camera`] if the camera returns an error.
-#[cfg_attr(feature = "tracing", tracing::instrument(level = "debug"))]
 pub fn get_capabilities_from_path(device: &Path) -> crate::Result<Formats> {
     let camera = rscam::Camera::new(
         device
@@ -157,7 +155,6 @@ pub fn get_capabilities_from_path(device: &Path) -> crate::Result<Formats> {
     get_capabilities(&camera)
 }
 
-#[cfg_attr(feature = "tracing", tracing::instrument(level = "trace", skip_all))]
 fn get_capabilities(camera: &rscam::Camera) -> crate::Result<Formats> {
     camera
         .formats()
@@ -183,7 +180,6 @@ fn get_capabilities(camera: &rscam::Camera) -> crate::Result<Formats> {
         .collect()
 }
 
-#[cfg_attr(feature = "tracing", tracing::instrument(level = "trace"))]
 fn get_resolutions(resolutions: ResolutionInfo) -> Vec<(u32, u32)> {
     match resolutions {
         ResolutionInfo::Discretes(r) => r,
@@ -194,7 +190,6 @@ fn get_resolutions(resolutions: ResolutionInfo) -> Vec<(u32, u32)> {
     }
 }
 
-#[cfg_attr(feature = "tracing", tracing::instrument(level = "trace"))]
 fn get_intervals(intervals: IntervalInfo) -> Vec<(u32, u32)> {
     match intervals {
         IntervalInfo::Discretes(r) => r,
@@ -213,7 +208,6 @@ fn get_intervals(intervals: IntervalInfo) -> Vec<(u32, u32)> {
 ///
 /// This function may return a [`Error::Other`] if any part of the config is invalid,
 /// including the V4L2 controls.
-#[cfg_attr(feature = "tracing", tracing::instrument(level = "debug", skip(caps)))]
 pub fn check_config(config: &Config, caps: &Capabilities) -> crate::Result<()> {
     caps.0
         .get(&config.device)