fixes for updi getting stuck on flash (#275)

VortexEngine/src/Menus/MenuList/EditorConnection.cpp

@@ -428,16 +428,13 @@ void EditorConnection::handleState()
       break;
     }
     UPDI::eraseMemory();
+
+
     m_curStep = 0;
     m_firmwareOffset = 0;
-    Leds::setAll(RGB_YELLOW3);
     m_receiveBuffer.clear();
+    Leds::setAll(RGB_YELLOW3);
     SerialComs::write(EDITOR_VERB_READY);
-    // TODO: this god awful delay idk why it's necessary but without 
-    // it the serial seems to get stuck. It appears like an esp internals
-    // issue with serial but maybe this logic is just buggy -- it runs fine
-    // when simulated in test framework connected to editor though
-    Time::delayMilliseconds(300);
     m_state = STATE_CHROMALINK_FLASH_FIRMWARE_RECEIVE;
     break;
   case STATE_CHROMALINK_FLASH_FIRMWARE_RECEIVE:
@@ -447,11 +444,6 @@ void EditorConnection::handleState()
     }
     // send ack
     SerialComs::write(EDITOR_VERB_FLASH_FIRMWARE_ACK);
-    // TODO: this god awful delay idk why it's necessary but without 
-    // it the serial seems to get stuck. It appears like an esp internals
-    // issue with serial but maybe this logic is just buggy -- it runs fine
-    // when simulated in test framework connected to editor though
-    Time::delayMilliseconds(5);
     // only once the entire firmware is written
     if (m_firmwareOffset >= m_firmwareSize) {
       // then done

VortexEngine/src/UPDI/updi.cpp

@@ -720,12 +720,12 @@ void UPDI::enterProgrammingMode()
     stcs(Control_A, 0x6);
     mode = cpu_mode<0xEF>();
     if (mode != 0x82 && mode != 0x21 && mode != 0xA2 && mode != 0x08) {
-      sendDoubleBreak();
+      //sendDoubleBreak();
+      sendBreak();
       uint8_t status = ldcs(Status_B);
       ERROR_LOGF("Bad CPU Mode 0x%02x... error: 0x%02x", mode, status);
-      reset();
+      //reset();
       continue;
-      //return false;
     }
     if (mode != 0x08) {
       sendProgKey();
@@ -734,7 +734,6 @@ void UPDI::enterProgrammingMode()
         ERROR_LOGF("Bad prog key status: 0x%02x", status);
         reset();
         continue;
-        //return false;
       }
       reset();
     }