Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to handle None values in IGD add_port_mapping/delete_port_mapping #209

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

StevenLooman
Copy link
Owner

@StevenLooman StevenLooman commented Nov 3, 2023

No need to handle None values in IGD add_port_mapping/delete_port_mapping, refs #208

@StevenLooman StevenLooman changed the title No need to handle None values, refs #208 No need to handle None values in IGD add_port_mapping/delete_port_mapping, refs #208 Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e05dae4) 72.43% compared to head (bc9fb45) 72.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #209   +/-   ##
============================================
  Coverage        72.43%   72.43%           
============================================
  Files               19       19           
  Lines             4041     4041           
============================================
  Hits              2927     2927           
  Misses            1114     1114           
Files Coverage Δ
async_upnp_client/profiles/igd.py 46.54% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StevenLooman StevenLooman changed the title No need to handle None values in IGD add_port_mapping/delete_port_mapping, refs #208 No need to handle None values in IGD add_port_mapping/delete_port_mapping Nov 3, 2023
@StevenLooman StevenLooman merged commit 0c717cb into development Nov 7, 2023
8 checks passed
@StevenLooman StevenLooman deleted the fix_208 branch November 7, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant