Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Because of mysql 8.x reserved keys the SORTBY rank does not work any … #30

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Because of mysql 8.x reserved keys the SORTBY rank does not work any … #30

wants to merge 1 commit into from

Conversation

dimitrihilverda
Copy link

…more. replaced it with the queries alias like FormaliciousAnswer_rank etc.

Because of mysql 8.x reserved keys the SORTBY rank does not work any …
5aa8f1c 
…more. replaced it with the queries alias like FormaliciousAnswer_rank etc.
Jako
Jako reviewed Jul 9, 2024
View reviewed changes
Copy link

@Jako Jako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the underscore to a dot since that is the normal xPDO field syntax.

_rank => .rank

Otherwise I am fine with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jako Jako Jako left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitrihilverda @Jako