Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable zookeeper when possible. Now only needed when replication factor must be changed with kafka < 2.4.0 or kafka <= 0.11.0 #79

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Disable zookeeper when possible. Now only needed when replication factor must be changed with kafka < 2.4.0 or kafka <= 0.11.0 #79

merged 4 commits into from
Feb 17, 2021

Conversation

ryarnyah
Copy link
Collaborator

@ryarnyah ryarnyah commented Feb 8, 2021 •
edited
Loading

Fixes #63

Proposed Changes

  • Use Kafka API most of the time
  • No longer need to use zookeeper if Kafka >= 2.4.0

@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch 2 times, most recently from 6e8f46a to 7d67a51 Compare February 8, 2021 16:20
@ryarnyah ryarnyah marked this pull request as draft February 8, 2021 16:29
@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch 2 times, most recently from dc9c25c to 2dc2268 Compare February 8, 2021 16:56
@ryarnyah ryarnyah marked this pull request as ready for review February 8, 2021 16:57
@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch from 2dc2268 to 245d43a Compare February 8, 2021 17:01
@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch 2 times, most recently from 71cb538 to 82b19cf Compare February 9, 2021 11:23
@ryarnyah ryarnyah changed the title Disable zookeeper when possible. Now only needed when replication factor must be changed or kafka <= 0.11.0 Disable zookeeper when possible. Now only needed when replication factor must be changed with kafka < 2.4.0 or kafka <= 0.11.0 Feb 9, 2021
@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch from 82b19cf to 3cce87a Compare February 9, 2021 11:32
@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch from 3cce87a to 581a699 Compare February 9, 2021 11:33
StephenSorriaux
StephenSorriaux reviewed Feb 16, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
module_utils/kafka_lib_topic.py Outdated Show resolved Hide resolved
module_utils/kafka_manager.py Show resolved Hide resolved
@ryarnyah ryarnyah force-pushed the feature/use-zookeeper-only-needed branch from 1698fdf to cb24588 Compare February 17, 2021 12:04
StephenSorriaux
StephenSorriaux approved these changes Feb 17, 2021
View reviewed changes
Copy link
Owner

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryarnyah ryarnyah merged commit 95c311c into master Feb 17, 2021
@StephenSorriaux StephenSorriaux deleted the feature/use-zookeeper-only-needed branch February 18, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenSorriaux StephenSorriaux StephenSorriaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency to Zookeeper when possible
2 participants
@ryarnyah @StephenSorriaux