홈 리팩토링 및 작동 보완 #170
Merged
홈 리팩토링 및 작동 보완 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestHome.tsx -> HomeVideoSlider.tsx
TestHome.tsx -> Home.tsx
더블클릭시에 잠시 보여주는 용도로, 버튼에서 div로 변경, onClick 이벤트는 삭제
hjiwon
commented
Nov 8, 2023
Comment on lines
+88
to
+115
| <SwiperSlide key={shortForm.profileShortFormUrl + index}> | ||
| <div ref={nextPageRef}></div> | ||
|
|
||
| <Swiper | ||
| modules={[A11y]} | ||
| grabCursor={true} | ||
| autoHeight={true} | ||
| direction={'horizontal'} | ||
| onSlideNextTransitionEnd={() => { | ||
| navigate(`/pet/${shortForm.petId}`); | ||
| }} | ||
| > | ||
| <SwiperSlide> | ||
| <HomeVideo | ||
| url={shortForm.profileShortFormUrl} | ||
| muted={muted} | ||
| handleDoubleClick={handleDoubleClick} | ||
| hovering={hovering} | ||
| setHovering={setHovering} | ||
| /> | ||
| </SwiperSlide> | ||
| <SwiperSlide> | ||
| <div className="w-full h-[90vh] flex items-center justify-center font-bold text-white bg-black"> | ||
| <div>동물 정보 가져오겠습니다~</div> | ||
| </div> | ||
| </SwiperSlide> | ||
| </Swiper> | ||
| </SwiperSlide> |
There was a problem hiding this comment.
return 문이 너무 거대해진 것 같아서..
map 내부의 개별적인 슬라이드들도 컴포넌트로 분리하는게 좋을지 고민입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현된 부분
미구현 부분
고민