Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign filter checkbox #634

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

mattias800
Copy link
Contributor

@mattias800 mattias800 commented Oct 23, 2023

New FilterCheckbox and FilterCheckboxList components.
These makes it easy to create checkbox list in filter with correct design.

"A la carte" has been navigated to with the keyboard.
"Attractions" is hover.

image

Version

Published prerelease version: v19.0.0-next.28

Changelog

💥 Breaking Change

  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels

🐛 Bug Fix

⚠️ Pushed to next

Authors: 4

…tent, such as Checkbox.

- Add new FilterCheckbox component, which is a row with checkbox designed for the filter.
- Add common focus outline CSS property to theme.
- Add common focus outline to checkbox. This should be applied to all focusable elements, but we are starting with checkbox.
@mattias800 mattias800 changed the base branch from master to next October 23, 2023 11:13
@github-actions
Copy link

Size Change: 0 B

Total Size: 389 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15.2 kB
packages/calendar/dist/index.js 12.9 kB
packages/core/dist/index.es.js 5.04 kB
packages/core/dist/index.js 4.66 kB
packages/elements/dist/index.es.js 127 kB
packages/elements/dist/index.js 125 kB
packages/filter/dist/index.es.js 3.88 kB
packages/filter/dist/index.js 3.27 kB
packages/forms/dist/index.es.js 6.83 kB
packages/forms/dist/index.js 6.23 kB
packages/grid-export/dist/index.es.js 2.05 kB
packages/grid-export/dist/index.js 1.99 kB
packages/grid/dist/index.es.js 16.7 kB
packages/grid/dist/index.js 13.9 kB
packages/input-mask/dist/index.es.js 814 B
packages/input-mask/dist/index.js 734 B
packages/modal/dist/index.es.js 3.42 kB
packages/modal/dist/index.js 3.09 kB
packages/panels/dist/index.es.js 7.12 kB
packages/panels/dist/index.js 6.29 kB
packages/redux/dist/index.es.js 3.06 kB
packages/redux/dist/index.js 2.75 kB
packages/select/dist/index.es.js 4.08 kB
packages/select/dist/index.js 3.65 kB
packages/theme/dist/index.es.js 2 kB
packages/theme/dist/index.js 2.06 kB
packages/tooltip/dist/index.es.js 2.92 kB
packages/tooltip/dist/index.js 2.72 kB

compressed-size-action

Copy link
Contributor

@lindskogen lindskogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's test this in FP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants