Skip to content

Commit

Permalink
Fix modal slide out animation bug (#924)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattias800 authored Nov 21, 2024
1 parent c29e829 commit ca9c21c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
9 changes: 1 addition & 8 deletions packages/modal/src/dialog/UseDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,7 @@ export function useDialog<TProps, TPromiseResolve = void>(
background={background}
>
<DialogContext.Provider value={contextValue}>
<div
style={contentWrapperStyle}
className={contentWrapperClassName}
>
{contentVisible && (
<Comp {...(modalComponentProps.current as TProps)} key={key} />
)}
</div>
<Comp {...(modalComponentProps.current as TProps)} key={key} />
</DialogContext.Provider>
</Modal>
) : (
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9295,9 +9295,9 @@ [email protected], "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0", react-dom@^18.3.1:
loose-envify "^1.1.0"
scheduler "^0.23.2"

react-draggable@^4.4.5:
[email protected].6:
version "4.4.6"
resolved "https://registry.npmjs.org/react-draggable/-/react-draggable-4.4.6.tgz"
resolved "https://registry.yarnpkg.com/react-draggable/-/react-draggable-4.4.6.tgz#63343ee945770881ca1256a5b6fa5c9f5983fe1e"
integrity sha512-LtY5Xw1zTPqHkVmtM3X8MUOxNDOUhv/khTgBgrUvwaS064bwVvxT+q5El0uUFNx5IEPKXuRejr7UqLwBIg5pdw==
dependencies:
clsx "^1.1.1"
Expand Down Expand Up @@ -9344,7 +9344,7 @@ react-lifecycles-compat@^3.0.0:
resolved "https://registry.npmjs.org/react-lifecycles-compat/-/react-lifecycles-compat-3.0.4.tgz"
integrity sha512-fBASbA6LnOU9dOU2eW7aQ8xmYBSXUIWr+UmF9b1efZBazGNO+rcXT/icdKnYm2pTwcRylVUYwW7H1PHfLekVzA==

react-modal@^3.16.1:
[email protected]:
version "3.16.1"
resolved "https://registry.yarnpkg.com/react-modal/-/react-modal-3.16.1.tgz#34018528fc206561b1a5467fc3beeaddafb39b2b"
integrity sha512-VStHgI3BVcGo7OXczvnJN7yT2TWHJPDXZWyI/a0ssFNhGZWsPmB8cF0z33ewDXq4VfYMO1vXgiv/g8Nj9NDyWg==
Expand Down

0 comments on commit ca9c21c

Please sign in to comment.