use bounded blob sidecar index

StefanBratanov · Nov 17, 2023 · aad6a7f · aad6a7f
1 parent 660bb1f
commit aad6a7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...c/main/java/tech/pegasys/teku/validator/coordinator/publisher/AbstractBlockPublisher.java b/...c/main/java/tech/pegasys/teku/validator/coordinator/publisher/AbstractBlockPublisher.java
@@ -61,7 +61,7 @@ public SafeFuture<SendSignedBlockResult> sendSignedBlock(
         .thenCompose(
             signedBlock -> {
               // creating blob sidecars after unblinding the block to ensure in the blinded flow we
-              // already have cached the builder payload
+              // will have the cached builder payload
               final List<BlobSidecar> blobSidecars =
                   blockFactory.createBlobSidecars(blockContainer);
               return gossipAndImportUnblindedSignedBlockAndBlobSidecars(

diff --git a/ethereum/spec/src/testFixtures/java/tech/pegasys/teku/spec/util/DataStructureUtil.java b/ethereum/spec/src/testFixtures/java/tech/pegasys/teku/spec/util/DataStructureUtil.java
@@ -2561,7 +2561,7 @@ public BlobSidecar build() {
               .getBlobSidecarSchema();
 
       return blobSidecarSchema.create(
-          index.orElse(randomUInt64()),
+          index.orElse(randomBlobSidecarIndex()),
           blob.orElse(randomBytes(blobSidecarSchema.getBlobSchema().getLength())),
           kzgCommitment.orElse(randomBytes48()),
           kzgProof.orElse(randomBytes48()),
@@ -2612,6 +2612,10 @@ public RewardAndPenaltyDeltas randomRewardAndPenaltyDeltas(final int validatorCo
     return rewardAndPenaltyDeltas;
   }
 
+  private UInt64 randomBlobSidecarIndex() {
+    return randomUInt64(spec.getMaxBlobsPerBlock().orElseThrow());
+  }
+
   private int randomNumberOfBlobsPerBlock() {
     // minimum 1 blob
     return randomInt(1, spec.getMaxBlobsPerBlock().orElseThrow() + 1);