Make UniqueStash generic over index type #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One motivation for this change is to be able to have smaller indices. As such, implement wrapping add for entry versions, for any number of bits up to 64.
Stebalien
reviewed
Jun 15, 2019
src/index.rs
Outdated
| /// Create a new UniqueIndex. | ||
| /// | ||
| /// This method should panic if `offset` is out of acceptable range. | ||
| fn new_index(offset: usize, version: u64) -> Self; |
There was a problem hiding this comment.
Nit: this should just be called "new".
|
I tried updating the documentation now but I not very happy with it. Feel very free to change anything/everything... you won't hurt my feelings. :) |
|
I'll try to review this as soon as I can but that probably won't be for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One motivation for this change is to be able to have smaller indices.
As such, implement wrapping add for entry versions, for any number of bits
up to 64.
I have not updated documentation yet to mention the re-using of versions.
I am also considering to store the empty/full tag in most significant bit of the version field (and changing from enum to union as you suggested). Another thing is that I also want to create macros for making it easier for users to create their on index types (implementing the Index and UniqueIndex traits). But that's for later, curious if you are interested in this change first.
Open question about the conversion to/from string that is implemented for Tag already. If using custom index type then no such conversion is provided but I think that's OK for now...?