Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CMsgClientMMSLobbyData with null metadata #828

Merged
merged 3 commits into from
Apr 18, 2020

Conversation

Benjamin-Dobell
Copy link
Contributor

Closes #826

@azuisleet
Copy link
Member

The assertion cachedLobby != null in HandleLobbyData, is that still correct for a lobby we discover through friend presence data? Will that normally be hit for such a case?

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #828 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   22.77%   22.77%           
=======================================
  Files          95       95           
  Lines        9331     9330    -1     
  Branches      772      779    +7     
=======================================
  Hits         2125     2125           
+ Misses       7072     7071    -1     
  Partials      134      134           
Impacted Files Coverage Δ
...SteamKit2/Steam/Handlers/SteamMatchmaking/Lobby.cs 0.00% <0.00%> (ø)
...team/Handlers/SteamMatchmaking/SteamMatchmaking.cs 3.77% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cfb95...87dbd3f. Read the comment docs.

@Benjamin-Dobell
Copy link
Contributor Author

Yeah, I don't believe it was ever accurate actually, it was added in:

c67f2ab#diff-afcd8513c5d05604d1e1610042a9f576R591

I'll add in a commit to this PR removing it.

@azuisleet
Copy link
Member

Ah yes, the assertion was for the previously non-nullable access to Members.

@yaakov-h yaakov-h merged commit 12390c5 into SteamRE:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnection when calling GetLobbyData() on a deleted lobby.
3 participants