-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update protos #1027
Open
yaakov-h
wants to merge
10
commits into
master
Choose a base branch
from
yaakov/auto-protos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
19d07ba
Initial attempt at proto update automation
yaakov-h 10af2ea
fix options syntax
yaakov-h c0f49cd
tweaks to submodule fetching
yaakov-h 356464f
rename action
yaakov-h a73b51e
Fix casing in regen script
yaakov-h 2d5df93
Create PR when run
yaakov-h a6d8986
disable side effects pending discussion
yaakov-h 79ea12c
Simplify
yaakov-h 8c60dc5
try init'ing submodules first
yaakov-h 1f69225
Update update-protobufs.yaml
xPaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: Update Protobufs | ||
|
||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- yaakov/auto-protos # temporary trigger during development | ||
#schedule: | ||
#- cron: '0 17 * * SUN' | ||
|
||
permissions: | ||
contents: write | ||
pull-requests: write | ||
|
||
jobs: | ||
update-protobufs: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/[email protected] | ||
with: | ||
submodules: true | ||
|
||
- name: Run update script | ||
shell: pwsh | ||
run: Resources/ProtobufGen/update.ps1 | ||
|
||
# TODO: We need a new GitHub Machine Account (or maybe an existing one?) to generate a PAT that we can use as the token here | ||
# otherwise, our new changes will not trigger further Actions (on:push or on:pull_request, i.e. CI/CD builds). | ||
#- name: Create Pull Request | ||
# uses: peter-evans/create-pull-request@v6 | ||
# with: | ||
# #token: ${{ secrets.PAT }} | ||
# commit-message: Update protobufs | ||
# title: Update protobufs | ||
# body: | | ||
# - Update protobufs | ||
# branch: auto/protobufs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just dropping a comment for this to be uncommented once we're ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also add
workflow_dispatch:
to be able to manually trigger this from UI.