Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new text input to manage filers page #212

Merged
merged 2 commits into from
Jul 23, 2024
Merged

added new text input to manage filers page #212

merged 2 commits into from
Jul 23, 2024

Conversation

mathis-marcotte
Copy link

@mathis-marcotte mathis-marcotte added the auto-deploy Trigger manual CI steps for this CI label Jul 19, 2024
@mathis-marcotte
Copy link
Author

Before merging, I want to add some validation to the new input

bryanpaget
bryanpaget reviewed Jul 23, 2024
View reviewed changes
Copy link

@bryanpaget bryanpaget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@mathis-marcotte mathis-marcotte merged commit 7e710a0 into kubeflow-aaw2.0 Jul 23, 2024
3 checks passed
@mathis-marcotte mathis-marcotte deleted the manage-filers-custom-shares branch July 23, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanpaget bryanpaget bryanpaget approved these changes

Assignees
No one assigned
Labels
auto-deploy Trigger manual CI steps for this CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathis-marcotte @bryanpaget