Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button text and function #183

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Update button text and function #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/centraldashboard/public/assets/i18n/languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"landingPage.slackLink": "https://statcan-aaw.slack.com",
"landingPage.firstTime": "This seems to be the first time you access Kubeflow, we are happy to see you!",
"landingPage.autoNamespace": "Your namespace is automatically generated.",
"notebookDefaultCard.connect": "Connect",
"notebookDefaultCard.goto": "Go to Notebooks",
"notebookDefaultCard.create": "Create",
"notebookDefaultCard.details": "Details",
"notebookDefaultCard.name": "Name",
Expand Down Expand Up @@ -181,7 +181,7 @@
"notebookCard.errRetrievingNotebooks": "Erreur en récupérant les bloc-notes",
"notebookCard.errNoNotebooks": "Pas de bloc-notes dans l'espace de noms {namespace}",
"notebookCard.txtAccessed": "Accédé ",
"notebookDefaultCard.connect": "Connecter",
"notebookDefaultCard.connect": "Aller au bloc-notes",
"notebookDefaultCard.create": "Créer",
"notebookDefaultCard.details": "Détails",
"notebookDefaultCard.name": "Nom",
Expand Down
6 changes: 3 additions & 3 deletions components/centraldashboard/public/components/notebook-default-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ export class NotebookDefaultCard
return this.defaultNotebook.notebook.status.phase == 'ready';
}

_connectNotebook() {
// eslint-disable-next-line max-len
window.open(`/notebook/${this.namespace}/${this.defaultNotebook.notebook.name}/`);
// Changing this code for now to open the notebooks page instead
_goToNotebook() {
window.open(`/_/${this.language}/?ns=/${this.namespace}/`);
}

_detailNotebook() {
Expand Down
2 changes: 1 addition & 1 deletion components/centraldashboard/public/components/notebook-default-card.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ paper-card#DefaultNotebookCard(heading="{{localize('notebookDefaultCard.txtDefau
p {{localize('notebookDefaultCard.type')}}: {{defaultNotebook.notebook.serverType}}
div.button-div
paper-button(on-click='_detailNotebook') {{localize('notebookDefaultCard.details')}}
paper-button(on-click='_connectNotebook') {{localize('notebookDefaultCard.connect')}}
paper-button(on-click='_goToNotebook') {{localize('notebookDefaultCard.goto')}}
paper-toast#DefaultNotebookError(duration=8000)
|{{localize('notebookDefaultCard.errorDefaultNotebook')}}
strong [[defaultNotebookError]]
Loading