Correction after feedback

StatCan · Jun 10, 2024 · e87d46d · e87d46d
1 parent 6f1be95
commit e87d46d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/components/centraldashboard/cypress/e2e/landing-page.cy.ts b/components/centraldashboard/cypress/e2e/landing-page.cy.ts
@@ -24,7 +24,7 @@ describe('Landing Page', () => {
     cy.get('main-page').shadow().find('landing-page').shadow().find('#MainCard > neon-animatable > div > #namespaceDisplay').find('span').should('exist').and('have.text', 'user-name');
   });
 
-  it('should email keep number', ()=>{
+  it('Email number should stay in namespace', ()=>{
     cy.intercept('GET', `/api/workgroup/exists`, {
       "hasAuth":true,
       "user":"[email protected]",
@@ -36,10 +36,6 @@ describe('Landing Page', () => {
     cy.visit('/');
 
     cy.wait(['@mockWorkgroupRequest', '@mockDashboardLinksRequest']);
-    cy.get('main-page').shadow().find('blocked-user-view').should('not.be.visible');
-    cy.get('main-page').shadow().find('landing-page').should('exist');
-    cy.get('main-page').shadow().find('landing-page').shadow().find('#MainCard > neon-animatable > h2').should('have.text', 'Welcome');
-    cy.get('main-page').shadow().find('landing-page').shadow().find('#MainCard > neon-animatable > p').find('a').should('exist').and('have.prop', 'href', 'https://zone.pages.cloud.statcan.ca/docs/en/');
     cy.get('main-page').shadow().find('landing-page').shadow().find('#MainCard > neon-animatable > div > #emailDisplay').find('span').should('exist').and('have.text', '[email protected]');
     cy.get('main-page').shadow().find('landing-page').shadow().find('#MainCard > neon-animatable > div > #namespaceDisplay').find('span').should('exist').and('have.text', 'user-name1');
   });

diff --git a/components/centraldashboard/public/assets/i18n/languages.json b/components/centraldashboard/public/assets/i18n/languages.json
@@ -74,7 +74,6 @@
             "landingPage.errCreateNS": "An error occured while creating the workspace.",
             "landingPage.errGetNS": "An error occured while trying to retrieve the workspace",
             "landingPage.errCreateDefaultNotebook": "An error occured while trying to create the default notebook",
-            "landingPage.errGeneral": "An unexpected error occured, details available in English:",
             "blockedUserPage.text": "The dev environment is only accessible to developers.",
             "notebookDefaultCard.goto": "Go to Notebooks",
             "notebookDefaultCard.create": "Create",
@@ -222,7 +221,6 @@
             "landingPage.errCreateNS": "Une erreur s'est produite lors de la création de l'espace de travail.",
             "landingPage.errGetNS": "Une erreur s'est produite lors de la tentative de récupération de l'espace de travail",
             "landingPage.errCreateDefaultNotebook": "Une erreur s'est produite lors de la tentative de création du notebook par défaut",
-            "landingPage.errGeneral": "Une erreur inattendue s'est produite, détails disponibles en anglais :",
             "blockedUserPage.text": "L'environment Dev est seulement pour les développeurs.",
             "registrationPage.btnNext": "Suivant",
             "registrationPage.btnStartSetup": "Commencer",

diff --git a/components/centraldashboard/public/components/landing-page.js b/components/centraldashboard/public/components/landing-page.js
@@ -42,7 +42,6 @@ export class LandingPage extends mixinBehaviors([AppLocalizeBehavior], utilities
             emailAddress: {type: String, observer: '_onEmailAddress'},
             namespaceName: String,
             errorText: {type: String, value: ''},
-            errorDetail: {type: String, value: ''},
             flowComplete: {type: Boolean, value: false},
             loading: {type: Boolean, value: false},
             isStatcanEmail: {type: Boolean, value: false},
@@ -117,12 +116,10 @@ export class LandingPage extends mixinBehaviors([AppLocalizeBehavior], utilities
     showError(err) {
         this.loading = false;
         this.errorText = err;
-        this.errorDetail = '';
     }
 
     closeError() {
         this.errorText = '';
-        this.errorDetail = '';
     }
 
     _onCreateNamespaceError() {