Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OMPP model addition docs #1949

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Update OMPP model addition docs #1949

merged 4 commits into from
Jan 29, 2024

Conversation

Souheil-Yazji
Copy link
Contributor

@Souheil-Yazji Souheil-Yazji commented Jan 26, 2024 •
edited
Loading

@KrisWilliamson KrisWilliamson self-requested a review January 29, 2024 14:42
KrisWilliamson
KrisWilliamson previously approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@KrisWilliamson KrisWilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the links to the pictures are broken.

@Souheil-Yazji Souheil-Yazji mentioned this pull request Jan 29, 2024
Closed
@Souheil-Yazji Souheil-Yazji merged commit 07be6f1 into master Jan 29, 2024
0 of 2 checks passed
@Souheil-Yazji Souheil-Yazji deleted the ompp-model-docs branch January 29, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacek-dudek jacek-dudek jacek-dudek approved these changes

@KrisWilliamson KrisWilliamson KrisWilliamson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Souheil-Yazji @jacek-dudek @KrisWilliamson