enable switching to https on login page #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble config to toggle https mode on mocks
elvece
force-pushed
the
update/switch-https-login
branch
from
9b8afc5 to
804380c
Compare
MattDHill
previously approved these changes
Sep 11, 2023
…witch-https-login
MattDHill
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a banner to login page in similar fashion to other pages, prompting the user to switch to an HTTPS connection.
@MattDHill
storefront-outlineis already in the preloader component - I noticed it loaded last in the sidebar menu over tor, with no delay on the updates page, and with no delay in the marketplace. Is this what you experienced?