Modify createPostSyncRunner to handle redirects #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Taplint validator produces failed jobs during the QPO stages (synchronous POST queries) for the Rubin TAP service.
The sync POST queries in our case return a 303 redirect to the results, which I think are standard complient, but as far as I can tell are not handled in this stage, as the exception implies that the redirect is not followed.
The headers of a sync POST request using a cli client to our TAP service looks like this:
Error logs
Fix
The proposed fix adds a check to the Post Sync job handling code to check the headers for a 303, and use the AuthManager if it exists to connect to and return a connection to the location url.
Feel free to ignore PR if you disagree or think this is the wrong approach