[Enhancement] fix compilable issue in UnmodifiableCollectionsSerializer #55016
Conversation
zhaohehuhu
changed the title
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| throw new IllegalArgumentException("The type " + type + " is not supported."); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
Casting of collections may lead to ClassCastException.
You can modify the code like this:
private Collection<?> getValues(Object coll) {
if (coll instanceof Collection) {
return new ArrayList<>((Collection<?>) coll);
}
throw new IllegalArgumentException("Provided object is not a collection.");
}Additionally, it's essential to ensure that other parts of the code that use casting to specific collection types verify the type before casting. This adjustment prevents runtime exceptions when non-collection objects are passed inadvertently.
|
@gengjun-git plz help review the code. |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package com.starrocks.connector.iceberg; |
There was a problem hiding this comment.
could you move it to this package com.starrocks.connector.share.iceberg ? and remove this package org.apache.iceberg class with the same name
There was a problem hiding this comment.
Done @stephen-shelby
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
|
[Java-Extensions Incremental Coverage Report]coverage check fail. please retry. 😨 Please let me know when error again. com.naver.nid.cover.parser.coverage.exception.ParseException: java.nio.file.NoSuchFileException: /home/runner/_work/starrocks/starrocks/java-extensions/result |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Why I'm doing:
as title
What I'm doing:
Copy UnmodifiableCollectionsSerializer.java to sr repository to fix compilable issue:
Unable to make field final java.util.Collection java.util.Collections$UnmodifiableCollection.c accessible: module java.base does not "opens java.util" to unnamed module @61322f9d
Refer to magro/kryo-serializers#131
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: