Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add tuning guides to query profile #53421

Merged

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Dec 2, 2024

Why I'm doing:

if user's plan has been rewritten by the plan advisor of the feedback, and we need to get relevant information through the query profile
image

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stephen-shelby stephen-shelby requested a review from a team as a code owner December 2, 2024 08:53
@stephen-shelby stephen-shelby changed the title [Enhancement] add tuning guides to query profile [UT] add tuning guides to query profile Dec 2, 2024
@github-actions github-actions bot added the 3.4 label Dec 2, 2024
@stephen-shelby stephen-shelby changed the title [UT] add tuning guides to query profile [Enhancement] add tuning guides to query profile Dec 2, 2024
kangkaisen
kangkaisen previously approved these changes Dec 2, 2024
@stephen-shelby stephen-shelby force-pushed the add_advisor_to_trace_log branch 2 times, most recently from b453ce0 to 5c73aea Compare December 2, 2024 09:35
@stephen-shelby stephen-shelby changed the title [Enhancement] add tuning guides to query profile [UT] add tuning guides to query profile Dec 2, 2024
Copy link

sonarcloud bot commented Dec 2, 2024

@stephen-shelby stephen-shelby changed the title [UT] add tuning guides to query profile [Enhancement] add tuning guides to query profile Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 2, 2024

[FE Incremental Coverage Report]

pass : 6 / 6 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/feedback/PlanTuningAdvisor.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/Optimizer.java 4 4 100.00% []

Copy link

github-actions bot commented Dec 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit 8977a59 into StarRocks:main Dec 2, 2024
56 checks passed
Copy link

github-actions bot commented Dec 2, 2024

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 2, 2024
@stephen-shelby stephen-shelby deleted the add_advisor_to_trace_log branch December 2, 2024 15:22
Copy link
Contributor

mergify bot commented Dec 2, 2024

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants