-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] add tuning guides to query profile #53421
Merged
stephen-shelby
merged 1 commit into
StarRocks:main
from
stephen-shelby:add_advisor_to_trace_log
Dec 2, 2024
Merged
[Enhancement] add tuning guides to query profile #53421
stephen-shelby
merged 1 commit into
StarRocks:main
from
stephen-shelby:add_advisor_to_trace_log
Dec 2, 2024
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-shelby
changed the title
[Enhancement] add tuning guides to query profile
[UT] add tuning guides to query profile
Dec 2, 2024
stephen-shelby
changed the title
[UT] add tuning guides to query profile
[Enhancement] add tuning guides to query profile
Dec 2, 2024
kangkaisen
previously approved these changes
Dec 2, 2024
stephen-shelby
force-pushed
the
add_advisor_to_trace_log
branch
2 times, most recently
from
December 2, 2024 09:35
b453ce0
to
5c73aea
Compare
stephen-shelby
changed the title
[Enhancement] add tuning guides to query profile
[UT] add tuning guides to query profile
Dec 2, 2024
Signed-off-by: stephen <[email protected]>
stephen-shelby
force-pushed
the
add_advisor_to_trace_log
branch
from
December 2, 2024 10:35
5c73aea
to
0e7a9f9
Compare
Quality Gate passedIssues Measures |
stephen-shelby
changed the title
[UT] add tuning guides to query profile
[Enhancement] add tuning guides to query profile
Dec 2, 2024
murphyatwork
approved these changes
Dec 2, 2024
Seaven
approved these changes
Dec 2, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 6 / 6 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
Signed-off-by: stephen <[email protected]> (cherry picked from commit 8977a59)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 3, 2024
…53438) Co-authored-by: stephen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
if user's plan has been rewritten by the plan advisor of the feedback, and we need to get relevant information through the query profile
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: