Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] check tuple id is in Descriptor table #53412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

before-Sunrise
Copy link
Contributor

@before-Sunrise before-Sunrise commented Dec 2, 2024

Why I'm doing:

crash like below is because tuple id is not in Descriptor table, so nullptr will be return, and visit nullptr cause crash

@ 0x2d66a6b starrocks::RowDescriptor::init_tuple_idx_map()

 @ 0x2d66cc5 starrocks::RowDescriptor::RowDescriptor()

 @ 0x34ad786 starrocks::ExecNode::ExecNode()

 @ 0x36aa444 starrocks::AssertNumRowsNode::AssertNumRowsNode()

 @ 0x34addbd starrocks::ExecNode::create_vectorized_node()

 @ 0x34aee16 starrocks::ExecNode::create_tree_helper()

 @ 0x34af0fd starrocks::ExecNode::create_tree()

 @ 0x37c8bc2 starrocks::pipeline::FragmentExecutor::_prepare_exec_plan()

 @ 0x37ce80d starrocks::pipeline::FragmentExecutor::prepare()

 @ 0x591422b starrocks::PInternalServiceImplBase<>::_exec_plan_fragment_by_pipeline()

 @ 0x591b819 starrocks::PInternalServiceImplBase<>::_exec_plan_fragment()

 @ 0x5926ae5 starrocks::PInternalServiceImplBase<>::_exec_plan_fragment()

 @ 0x2cb460d starrocks::PriorityThreadPool::work_thread()

What I'm doing:

check in FE so BE won't crash, make query dump skip this check for debug purpose

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: before-Sunrise <[email protected]>
Copy link

sonarcloud bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants