Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add runtime cpu flags check #53407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Dec 2, 2024

  • abort at starting phase if the binary is not possible to run in the given cpu instruction set.

Why I'm doing:

What I'm doing:

Fixes #53401

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai kevincai requested a review from a team as a code owner December 2, 2024 06:27
* abort at starting phase if the binary is not possible to run in the
  given cpu instruction set.

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Copy link

github-actions bot commented Dec 2, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 2, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 2, 2024

[BE Incremental Coverage Report]

fail : 5 / 10 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/cpu_info.cpp 4 8 50.00% [493, 526, 529, 530]
🔵 be/src/common/daemon.cpp 1 2 50.00% [337]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Explicit cpu instruction check failure on be/cn daemon startup
1 participant