Optimization Logic

Signed-off-by: edwinhzhang <[email protected]>
StarRocks · Nov 28, 2024 · 07ca645 · 07ca645
1 parent 4f84a48
commit 07ca645
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/transaction/DatabaseTransactionMgr.java b/fe/fe-core/src/main/java/com/starrocks/transaction/DatabaseTransactionMgr.java
@@ -1207,13 +1207,7 @@ public void finishTransaction(long transactionId, Set<Long> errorReplicaIds) thr
             finishSpan.end();
         }
 
-        writeLock();
-        try {
-            transactionState.resetTabletCommitInfos();
-        } finally {
-            writeUnlock();
-        }
-
+        resetTransactionStateTabletCommitInfos(transactionState);
         transactionState.notifyVisible();
         // do after transaction finish
         GlobalStateMgr.getCurrentState().getOperationListenerBus().onStreamJobTransactionFinish(transactionState);
@@ -1914,13 +1908,7 @@ public void finishTransactionNew(TransactionState transactionState, Set<Long> pu
             finishSpan.end();
         }
 
-        writeLock();
-        try {
-            transactionState.resetTabletCommitInfos();
-        } finally {
-            writeUnlock();
-        }
-
+        resetTransactionStateTabletCommitInfos(transactionState);
         // do after transaction finish
         GlobalStateMgr.getCurrentState().getOperationListenerBus().onStreamJobTransactionFinish(transactionState);
         GlobalStateMgr.getCurrentState().getLocalMetastore().handleMVRepair(transactionState);
@@ -2082,4 +2070,13 @@ public List<Object> getSamplesForMemoryTracker() {
             readUnlock();
         }
     }
+
+    public void resetTransactionStateTabletCommitInfos(TransactionState transactionState) {
+        writeLock();
+        try {
+            transactionState.resetTabletCommitInfos();
+        } finally {
+            writeUnlock();
+        }
+    }
 }