Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger volumes #908

Open
wants to merge 17 commits into
base: og-develop
Choose a base branch
from
Open

Trigger volumes #908

wants to merge 17 commits into from
+130 −88

Conversation

hang-yin
Copy link
Contributor

@hang-yin hang-yin commented Sep 26, 2024 •
edited
Loading

Implements #882

  • Consider trigger report events: og.sim.psi.subscribe_physics_trigger_report_events
  • Verify with flatcache on

@hang-yin hang-yin self-assigned this Sep 26, 2024
@cgokmen cgokmen added this to the v1.2.0 milestone Oct 1, 2024
@hang-yin hang-yin marked this pull request as ready for review October 15, 2024 00:03
@cgokmen
Copy link
Contributor

cgokmen commented Nov 18, 2024

@hang-yin figure out if this works w/ flatcache. if not, how do we use the callback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgokmen cgokmen Awaiting requested review from cgokmen

At least 1 approving review is required to merge this pull request.

Assignees

@hang-yin hang-yin

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hang-yin @cgokmen