Tidy up #144
Merged
Tidy up #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,13 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def merge_dicts(*dicts): | |||
There was a problem hiding this comment.
This works but what benefit does it have over the previous implementation?
There was a problem hiding this comment.
dict1 = {'a': 1, 'b': None}
dict2 = {'a': 2, 'b': 3, 'c': 4}
dict(dict1, **dict2) == {'a': 2, 'b': 3, 'c': 4)
dict(dict2, **dict1) == {'a': 1, 'b': None, 'c': 4}
merge_dicts(dict1, dict2) == {'a': 2, 'b': 3, 'c': 4}
merge_dicts(dict2, dict1) == {'a': 1, 'b': 3, 'c': 4} # this is crucial one
Thomas-Lemoine
approved these changes
Aug 21, 2023
| @@ -155,7 +156,10 @@ def get_first_child(item): | |||
| ] | |||
|
|
|||
| if date_published := contents.select_one("div.ltx_dates"): | |||
| date_published = date_published.text.strip("()") | |||
| try: | |||
There was a problem hiding this comment.
just noticed while merging #97 into main that if there's a ParserError, the behaviour
"If the date couldn't be parsed, hope that later phases will be more successful"
is probably a typo. maybe you mean to log it or to return it as an error, but date_published probably ought to be None?
There was a problem hiding this comment.
maybe just pass and have that as a comment, too
There was a problem hiding this comment.
selected_date = contents.select_one("div.ltx_dates")
try:
date_published = parse(selected_date.text.strip("()")) if selected_date else None
except ParserError:
# "If the date couldn't be parsed, hope that later phases will be more successful"
date_published = None?
There was a problem hiding this comment.
ok I modified it there, #97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple more small bugs: