-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade logger to 2.0.1 #18
chore(deps): upgrade logger to 2.0.1 #18
Conversation
@ferrarafer can you please have a look at this one? |
@ferrarafer & @FilledStacks any news for this one? |
@FilledStacks & @ferrarafer is there a reason why not to upgrade to logger v2? |
@sebastianbuechler I think the logger package upgrade could break the package because we already did it and something went wrong. I will take a look as soon as possible. |
This would be a breaking change for the framework, we'll have to see how we can do it without causing a break first. If we can't we need to have the documentation ready to migrate over. |
@ferrarafer Any news on this? It seems to be blocking some other upgrades and increasing. |
@sebastianbuechler we'll release this on a beta branch as it's a breaking change. Sorry for the delay. |
BREAKING CHANGE * upgrade logger to 2.0.1 * exchange pretty printer default values * adjust unit tests for logger * remove warnings --------- Co-authored-by: Fernando Ferrara <[email protected]>
Hi @sebastianbuechler, I made a prerelease. Please, let me know if you find any issues. Should be 2.0.0-pre.1 but it didn't take the BREAKING CHANGE into account, I will see if we can change it tomorrow. |
Updated
logger
package to version 2.0.1 and adjusted code in generator and unit tests.Most critical changes: According to https://pub.dev/packages/logger/changelog the
init
,destroy
andclose
method are now async.Closes #15.