Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade logger to 2.0.1 #18

Conversation

sebastianbuechler
Copy link

@sebastianbuechler sebastianbuechler commented Aug 30, 2023

Updated logger package to version 2.0.1 and adjusted code in generator and unit tests.

Most critical changes: According to https://pub.dev/packages/logger/changelog the init , destroy and close method are now async.

Closes #15.

@sebastianbuechler sebastianbuechler changed the title Chore(deps): upgrade-logger-to-2.0.1 chore(deps): upgrade-logger-to-2.0.1 Aug 30, 2023
@sebastianbuechler
Copy link
Author

@ferrarafer can you please have a look at this one?

@sebastianbuechler
Copy link
Author

@ferrarafer & @FilledStacks any news for this one?

@sebastianbuechler
Copy link
Author

@FilledStacks & @ferrarafer is there a reason why not to upgrade to logger v2?

@ferrarafer
Copy link
Contributor

@sebastianbuechler I think the logger package upgrade could break the package because we already did it and something went wrong. I will take a look as soon as possible.

@FilledStacks
Copy link
Contributor

This would be a breaking change for the framework, we'll have to see how we can do it without causing a break first.

If we can't we need to have the documentation ready to migrate over.

@sebastianbuechler
Copy link
Author

@ferrarafer Any news on this? It seems to be blocking some other upgrades and increasing.

@FilledStacks
Copy link
Contributor

@sebastianbuechler we'll release this on a beta branch as it's a breaking change.

Sorry for the delay.

@ferrarafer ferrarafer changed the base branch from main to beta April 9, 2024 02:17
@ferrarafer ferrarafer changed the title chore(deps): upgrade-logger-to-2.0.1 chore(deps): upgrade logger to 2.0.1 Apr 9, 2024
@ferrarafer ferrarafer merged commit 311f67c into Stacked-Org:beta Apr 9, 2024
1 check failed
ferrarafer added a commit that referenced this pull request Apr 9, 2024
BREAKING CHANGE

* upgrade logger to 2.0.1
* exchange pretty printer default values
* adjust unit tests for logger
* remove warnings

---------

Co-authored-by: Fernando Ferrara <[email protected]>
@ferrarafer
Copy link
Contributor

ferrarafer commented Apr 9, 2024

Hi @sebastianbuechler, I made a prerelease. Please, let me know if you find any issues.

Should be 2.0.0-pre.1 but it didn't take the BREAKING CHANGE into account, I will see if we can change it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants