Fix flanker dependency package version to maintain py2 support

[punkrokk]

Fixes: #27 - See issue for details

[arm4b]

👍

Thanks for the fix!

[punkrokk]

Thanks for approving. LMK what else is needed to get this merged. @blag ?

[blag]

NAK. This just buries the fix in a separate package. Instead, I think it's cleaner and easier to simply specify a Python 2.7-only dependency along with a general dependency in requirements.txt, like so:

tld<0.11; python_version < '3.0'
tld

When installed in an environment with Python < 3.0, it will limit tld to 0.10 or 0.10.x. When installed in an environment with Python >= 3.0, it will install any version of tld.

@punkrokk @armab What do you think of that?

Sources:

• https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers
• https://stackoverflow.com/a/33451105

Edit: I should also add that this works because flanker currently doesn't even partially pin its version of tld. If that project ever does pin the tld version that doesn't overlap with <0.10, then this will break. However, Python 2.7 is dead-dead in less than a month, so I don't think it's a huge deal.

[blag]

NAK

[punkrokk]

I love it. I didn’t know that trick. Cheers, JP

…

On Dec 11, 2019, at 2:01 AM, blag ***@***.***> wrote:  NAK. This just buries the fix in a separate package. Instead, I think it's cleaner and easier to simply specify a Python 2.7-only dependency along with a general dependency in requirements.txt, like so: tld<0.11; python_version < '3.0' tld When installed in an environment with Python < 3.0, it will limit tld to 0.10 or 0.10.x. When installed in an environment with Python >= 3.0, it will install any version of tld. @punkrokk @armab What do you think of that? Sources: https://pip.pypa.io/en/stable/reference/pip_install/#requirement-specifiers https://stackoverflow.com/a/33451105 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[arm4b]

Same here, nice trick I didn't know about.

Thanks @blag!

[blag]

Closing in favor of #29.