Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesign review commenting as upload of JSON artifact #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Jun 18, 2021

Fix #111

@slarse slarse changed the title feat: Redesign review commenting as upload of JSON feat: Redesign review commenting as upload of JSON artifact Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #112 (935cc8d) into main (958ffc6) will decrease coverage by 0.64%.
The diff coverage is 44.11%.

❗ Current head 935cc8d differs from pull request most recent head a130d29. Consider uploading reports for the commit a130d29 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   86.97%   86.33%   -0.65%     
==========================================
  Files           7        7              
  Lines         261      278      +17     
  Branches       32       33       +1     
==========================================
+ Hits          227      240      +13     
- Misses         33       37       +4     
  Partials        1        1              
Impacted Files Coverage Δ
src/action.ts 64.63% <14.28%> (-11.13%) ⬇️
src/suggestions.ts 98.11% <92.30%> (+17.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958ffc6...a130d29. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign to upload review comments in JSON file instead of posting directly
1 participant