Update to ModLauncher 10 on SpongeVanilla #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They actually create more problems than they solve resulting in a bunch of unsafe casts
Yeregorix
force-pushed
the
api12/update-sv-ml
branch
from
f26a3a5
to
dc56426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponge | SpongeAPI
SpongeVanilla was still using ModLauncher 8 while SpongeForge is using ModLauncher 10. There are huge differences between these two versions. This PR solves this in order to facilitate future work related to ModLauncher and to properly support JPMS.
Notable changes:
-is deprecated. A warning is added to both SV and SF.MethodHandles.Lookup.plugin-spihas been modified. See SpongeAPI PR.modlauncher-patcherproject (hack to force upgrade ASM).