Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add files via upload #59

wants to merge 1 commit into from

Conversation

Ram750x
Copy link

@Ram750x Ram750x commented Jun 23, 2023

Proposed Changes

Added a RF switch driver to the Community collection.

Types of Changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New Project
  • [] Enhancement
  • [] Refactor
  • [] Bug Fix

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask @kalina-k. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Project name conforms to the naming convention described here

  • Project name is unique within the repository

  • Project exists in the appropriate directory based on its category and class, e.g. Drivers/Community

  • Project contains a file called documentation/readme.txt with metadata necessary for the catalog. The readme.txt file must contain these 4 lines at the top of the file:
    Project: Name of project.
    Description: 80 or so characters describing the contents of the project
    Category: ("driver" | "task" | "dashboard")
    Class: ("Community" | "Tested by Spirent" | "Reference")

    Other info like user instructions, a description of the intended use case, etc. can be added to the readme.txt after the 4 required lines.
    Note: A README.md file will be automatically generated including everything in the readme.txt file and a list of files, QuickCalls, and procedures with info from iTest's documentation fields. Do not create a README.md file, it will be overwritten. For the best possible documentation, fill out the description fields in each test case, procedure and QuickCall.

@alexorr
Copy link
Contributor

alexorr commented Jun 29, 2023

@Ram750x I can't approve this as-is for two reasons

  1. There's no device make/model in the project name or description
  2. The multi-link topology is not the most commonly used and is probably specific to one customer's application

Please resubmit with make and model name and using a typical L1 topology

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants