go api: fix regexp escape missing wildcard characters - #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See benw10-1/STR-Spire-Mod@3933f95 on the mod repo for generating deck strings from the mod output without needed to launch STS - includes case from running STS with the mod manually and getting the output directly from there
Fix issue where regexp escape causes wildcards to be missed. It happens in extreme-ish cases where the compressed deck string has more than 62 words and "regexp escaped" wildcards start to be used as tokens. By replacing each token using string replacement we don't need to escape thus never run into this issue.
MaT1g3R
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where
regexpescape causes wildcards to be missed.It happens in extreme-ish cases where the compressed deck string has more than 62 words and "
regexpescaped" wildcards start to be used as tokens.By replacing each token using string replacement we don't need to escape thus never run into this issue.
Tests in 686801e fail currently on master and pass on 5a9a705
Can generate further test-cases on mod commit 3933f95