-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go api: message content typing - broadcaster to own package #24
Open
benw10-1
wants to merge
45
commits into
Spireblight:master
Choose a base branch
from
benw10-1:feature/pubsub-typing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enticator and pubsub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial scope was basically converting
MessageContent
from amap[string]interface{}
to a concrete type.This accomplishes two things:
MessageContent
field. You can look at the type and see exact ref. to the STR modThe scope expanded a tiny bit because I had to change the function signatures for some of the broadcaster stuff.
See (#22) for API handler test initial implementation, this branched is based off of the API test branch. Needed some realistic tests as we need to ensure we are not breaking anything when the data entry-point is the Gin app.
Going to make a follow up PR for the Twitch PubSub endpoint stub and integration.
Going to make a follow up PR for Redis in CI pipeline for better DB testing.
Hopefully the addition of these types, the test-data, and tests on the endpoints should make failures less likely.