Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go api: message content typing - broadcaster to own package #24

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

benw10-1
Copy link

Initial scope was basically converting MessageContent from a map[string]interface{} to a concrete type.
This accomplishes two things:

  1. Makes more clear the usage path for the MessageContent field. You can look at the type and see exact ref. to the STR mod
  2. For stuff we are not reading and just forwarding, we don't have to marshal into a map then remarshal it to bytes when we are broadcasting

The scope expanded a tiny bit because I had to change the function signatures for some of the broadcaster stuff.

See (#22) for API handler test initial implementation, this branched is based off of the API test branch. Needed some realistic tests as we need to ensure we are not breaking anything when the data entry-point is the Gin app.

Going to make a follow up PR for the Twitch PubSub endpoint stub and integration.
Going to make a follow up PR for Redis in CI pipeline for better DB testing.

Hopefully the addition of these types, the test-data, and tests on the endpoints should make failures less likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant