Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verbose kwarg to mda write_recording #3535

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add verbose kwarg to mda write_recording #3535

merged 2 commits into from
Nov 19, 2024

Conversation

chrishalcrow
Copy link
Collaborator

Possible fix for #3532

Adds verbose as a kwarg to write_recording for MdaRecordingExtractor class, rather then it being in job_kwargs.

Probably missed when we removed verbose from job_kwargs. Does this look like a reasonable fix @zm711 ? This seems like a good time to check all the RecordingExtractors.

@chrishalcrow chrishalcrow mentioned this pull request Nov 13, 2024
Closed
@chrishalcrow chrishalcrow added the bug Something isn't working label Nov 13, 2024
zm711
zm711 reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's see what happens when you the user tests it :)

@chrishalcrow
Copy link
Collaborator Author

This has fixed (the first) problem in issue #3532 :
#3532 (comment)

@chrishalcrow chrishalcrow marked this pull request as ready for review November 15, 2024 09:33
zm711
zm711 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me unless @alejoe91 wanted something else :)

@alejoe91 alejoe91 merged commit e656f79 into SpikeInterface:main Nov 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrishalcrow @zm711 @alejoe91