Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in saving zarr recordings #3432

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

alejoe91
Copy link
Member

The times array loaded from zarr are converted to numpy arrays only when get_times is called. This resulted in an error when saving a zarr-based recording, since we were accessing times vector directly.

@alejoe91 alejoe91 added bug Something isn't working core Changes to core module labels Sep 23, 2024
@alejoe91 alejoe91 requested a review from zm711 September 23, 2024 08:01
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@alejoe91 alejoe91 merged commit 0e72755 into SpikeInterface:main Sep 23, 2024
15 checks passed
@alejoe91 alejoe91 added this to the 0.101.2 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Changes to core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants