Enable testing arm64 Mac architecture in the CI. #3422
Conversation
h-mayorquin
added
testing
|
Uh, that's great, it just... worked. |
h-mayorquin
changed the title
|
Ah, of course it was so easy, we did not have logic for running everything if the workflow files from github actions are changed. I added that. |
|
Ok, this is ready. I also eliminated a warning from the CI to keep things tidy 🧹 🧹 🧹 ( x D ) |
|
I think the only potentially slow step would be if we do a bunch of torch things, since pytorch defaults to the Mac CPU instead of GPU, but I don't even know what the runner GPU story is. |
| version.parse(platform.python_version()) >= version.parse("3.10"), | ||
| reason="Sonpy only testing with Python < 3.10!", | ||
| version.parse(platform.python_version()) >= version.parse("3.10") or platform.system() == "Darwin", | ||
| reason="Sonpy only testing with Python < 3.10 and not supported on macOS!", |
There was a problem hiding this comment.
Yes, want to give it a shot to have something that excludes intel cpus from mac? I think they stopped selling two years ago only so many people might still have them.
That said, I did not want to allocate extra effort to something that won't work in a year anyway (see the python restriction)
There was a problem hiding this comment.
I think that's fair. Let's not waste effort. our new Neo deprecation policy will also hit this one eventually.
There was a problem hiding this comment.
For me this is good to go. Based on a google intel Macs officially went end of life in JUNE2024. So only testing on officially supported hardware seems fair to me. And it looks like it successfully tested everything for complete tests so I think this should be good to go.
Moving forward with #3100.