Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics widgets for convert_dtypes #3417

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix metrics widgets for convert_dtypes #3417

merged 1 commit into from
Sep 16, 2024

Conversation

alejoe91
Copy link
Member

Moved some bug fixes out of #3370 for better logging :)

@alejoe91 alejoe91 added the widgets Related to widgets module label Sep 16, 2024
@alejoe91 alejoe91 requested a review from zm711 September 16, 2024 16:35
@alejoe91
Copy link
Member Author

@zm711 if you could approve this I'll go ahead wiht the review!

alejoe91 added a commit that referenced this pull request Sep 16, 2024
@alejoe91
Add #3417
ca0d99c
zm711
zm711 reviewed Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny question. Should we unify that someway? Why return None sometimes and np.nan other times. It might work better long-term if we can have consistent behavior?

@alejoe91
Copy link
Member Author

One tiny question. Should we unify that someway? Why return None sometimes and np.nan other times. It might work better long-term if we can have consistent behavior?

I think with the convert_dtypes it always returns None, but I left the nan part there since it doesn't hurt ;)

zm711
zm711 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks.

@alejoe91 alejoe91 merged commit 8a1870c into SpikeInterface:main Sep 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 approved these changes

Assignees
No one assigned
Labels
widgets Related to widgets module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoe91 @zm711