Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-cast recording to float prior to interpolation #3415

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

alejoe91
Copy link
Member

Fixes #3404

Thanks @jiumao2 for the suggestion

@alejoe91 alejoe91 added the motion correction Questions related to motion correction label Sep 16, 2024
alejoe91 added a commit that referenced this pull request Sep 16, 2024
@JoeZiminski
Copy link
Collaborator

Is it worth printing / warning a statement when the conversion is done? Just to indicate the conversion is done and file will be larger if saved now.

@alejoe91
Copy link
Member Author

Is it worth printing / warning a statement when the conversion is done? Just to indicate the conversion is done and file will be larger if saved now.

Thanks @JoeZiminski

Since the correct_motion is intended to be as high-level as possible, we thought we would just keep it silent and do whatever's needed to avoid failures. @samuelgarcia @jiumao2 what do you guys think?

@alejoe91
Copy link
Member Author

Actually I'll just go ahead and merge..I think that an extra warnign will be confusing for most usere :)

@alejoe91 alejoe91 merged commit 83bad08 into SpikeInterface:main Sep 16, 2024
15 checks passed
@jiumao2
Copy link
Contributor

jiumao2 commented Sep 16, 2024

Since the correct_motion is intended to be as high-level as possible, we thought we would just keep it silent and do whatever's needed to avoid failures. @samuelgarcia @jiumao2 what do you guys think?

That's great! I’ve actually already added that code to my spikeinterface!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
motion correction Questions related to motion correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't interpolate traces with dtype('int16')
4 participants