Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the method of creating an empty file with right size when saving binary files #3408

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Update the method of creating an empty file with right size when saving binary files #3408

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f0c72e
Update recording_tools.py
jiumao2 Sep 13, 2024
2cb34c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 13, 2024
3f9a901
Update src/spikeinterface/core/recording_tools.py
h-mayorquin Sep 14, 2024
d460c1e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 14, 2024
559cbaa
Update recording_tools.py
jiumao2 Sep 15, 2024
af6c618
Update recording_tools.py
jiumao2 Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/spikeinterface/core/recording_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,12 @@ def write_binary_recording(
data_size_bytes = dtype_size_bytes * num_frames * num_channels
file_size_bytes = data_size_bytes + byte_offset

file = open(file_path, "wb+")
file.truncate(file_size_bytes)
file.close()
# Create an empty file with file_size_bytes
with open(file_path, "wb+") as file:
# The previous implementation `file.truncate(file_size_bytes)` was slow on Windows (#3408)
file.seek(file_size_bytes - 1)
file.write(b"\0")

assert Path(file_path).is_file()

# use executor (loop or workers)
Expand Down
Loading