Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check run info completed only if it exists (back-compatibility) #3407

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Check run info completed only if it exists (back-compatibility) #3407

merged 1 commit into from
Sep 15, 2024

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 added the core Changes to core module label Sep 13, 2024
@alejoe91 alejoe91 added this to the 0.101.1 milestone Sep 13, 2024
zm711
zm711 reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm since I didn't fully follow this story, even if the run_info.json doesn't exist it won't error. It will just load as a None and that's why checking for None works?

@alejoe91
Copy link
Member Author

Just to confirm since I didn't fully follow this story, even if the run_info.json doesn't exist it won't error. It will just load as a None and that's why checking for None works?

Exactly :)

zm711
zm711 approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me then :)

@alejoe91 alejoe91 merged commit 667e4bd into SpikeInterface:main Sep 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 approved these changes

Assignees
No one assigned
Labels
core Changes to core module
Projects
None yet
Milestone
0.101.1
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoe91 @zm711