Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decision about headers to dev docs #3402

Merged

Conversation

h-mayorquin
Copy link
Collaborator

Should close #3019.

@h-mayorquin h-mayorquin added the documentation Improvements or additions to documentation label Sep 12, 2024
@h-mayorquin h-mayorquin self-assigned this Sep 12, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review September 12, 2024 15:40
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I just noticed a typo you could fix in l192. It is abbreviations (two b's).

alejoe91
alejoe91 previously approved these changes Sep 12, 2024
@alejoe91
Copy link
Member

Wee need a code block @h-mayorquin

image

@alejoe91 alejoe91 dismissed their stale review September 12, 2024 17:37

I was wrong

@zm711
Copy link
Collaborator

zm711 commented Sep 12, 2024

Nice catch Alessio!

@alejoe91 alejoe91 merged commit 8d9f8db into SpikeInterface:main Sep 12, 2024
15 checks passed
@h-mayorquin h-mayorquin deleted the add_header_decision_to_dev_doc branch September 12, 2024 19:25
@JoeZiminski
Copy link
Collaborator

Nice! Thanks @h-mayorquin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion on comment headers / sections to help split up the code
4 participants