Ensure sorting analyzer in zarr are consolidated #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgarcia
reviewed
Sep 9, 2024
|
@samuelgarcia this is fixed. The failing tests wa sa tricky one to find: basically we have to consolidate metadata AFTER run info is updated (and it was not the case) |
|
As discussed with @samuelgarcia, I also added the |
samuelgarcia
approved these changes
Sep 12, 2024
|
This sounds a bit annoying to do |
Yes. I think this should change once zarr v2 is out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title