Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time vector case to get_durations. #3118

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Add time vector case to get_durations. #3118

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22d025d
Add time vector case to 'get_durations'.
JoeZiminski Jul 1, 2024
f95c22a
Merge branch 'SpikeInterface:main' into add_time_vector_case_to_get_d…
JoeZiminski Jul 12, 2024
27360da
Extending sorting_analyzer 'get_total_duration' to use recording if a…
JoeZiminski Jul 12, 2024
31b94df
Start adding tests.
JoeZiminski Jul 15, 2024
e3d0311
Merge branch 'main' of github.com:SpikeInterface/spikeinterface into …
alejoe91 Jul 15, 2024
d69d578
Use num_samples instead of durations in hybrid tools
alejoe91 Jul 15, 2024
6b8c540
Add test for sorting analzyer total duration.
JoeZiminski Jul 15, 2024
7714724
Merge branch 'add_time_vector_case_to_get_duration' of https://github…
JoeZiminski Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/spikeinterface/core/baserecording.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,14 @@ def get_duration(self, segment_index=None) -> float:
The duration in seconds
"""
segment_index = self._check_segment_index(segment_index)
segment_num_samples = self.get_num_samples(segment_index=segment_index)
segment_duration = segment_num_samples / self.get_sampling_frequency()

if self.has_time_vector(segment_index):
times = self.get_times(segment_index)
segment_duration = times[-1] - times[0] + (1 / self.get_sampling_frequency())
h-mayorquin marked this conversation as resolved.
Show resolved Hide resolved
else:
segment_num_samples = self.get_num_samples(segment_index=segment_index)
segment_duration = segment_num_samples / self.get_sampling_frequency()

return segment_duration

def get_total_duration(self) -> float:
Expand All @@ -246,7 +252,7 @@ def get_total_duration(self) -> float:
float
The duration in seconds
"""
duration = self.get_total_samples() / self.get_sampling_frequency()
duration = sum([self.get_duration(idx) for idx in range(self.get_num_segments())])
return duration

def get_memory_size(self, segment_index=None) -> int:
Expand Down
Loading