Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plexon2 tests action for install wine and drop full (linux only) tests #3101

Merged
merged 11 commits into from
Jul 2, 2024
Merged

Add plexon2 tests action for install wine and drop full (linux only) tests #3101

merged 11 commits into from
Jul 2, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Jun 27, 2024 •
edited
Loading

Related to an effort to simplify tests in #3100.

This PR modifes the wine action so it works with the three operating systems. Other modifications to the testing suite:

  • Modifying plexon triggers the extractors test
  • Full testing deependencies delayed farther away after pre-processing
  • The data from gin is not downloaded unless the extractor suite is tested.

@h-mayorquin h-mayorquin added testing Related to test routines continuous integration Related to CI labels Jun 27, 2024
@h-mayorquin h-mayorquin requested a review from alejoe91 June 27, 2024 17:55
@h-mayorquin h-mayorquin self-assigned this Jun 27, 2024
@h-mayorquin h-mayorquin mentioned this pull request Jun 27, 2024
Open
14 tasks
@h-mayorquin
Copy link
Collaborator Author

This will need this merge on neo:

NeuralEnsemble/python-neo#1494

@h-mayorquin h-mayorquin marked this pull request as ready for review June 28, 2024 23:43
@h-mayorquin
Copy link
Collaborator Author

Ready to go @alejoe91

@alejoe91 alejoe91 added this to the 0.101.0 milestone Jul 1, 2024
alejoe91
alejoe91 reviewed Jul 2, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@h-mayorquin
Copy link
Collaborator Author

Thanks guys @alejoe91 @samuelgarcia .

Merging

@h-mayorquin h-mayorquin merged commit a178b7e into SpikeInterface:main Jul 2, 2024
16 checks passed
@h-mayorquin h-mayorquin deleted the add_plexon_to_full_tests branch July 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 left review comments

@alejoe91 alejoe91 alejoe91 approved these changes

@samuelgarcia samuelgarcia samuelgarcia approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
continuous integration Related to CI testing Related to test routines
Projects
None yet
Milestone
0.101.0
Development

Successfully merging this pull request may close these issues.
4 participants
@h-mayorquin @samuelgarcia @alejoe91 @zm711