Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reordering recording, sorting args #3094

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Reordering recording, sorting args #3094

merged 8 commits into from
Jun 28, 2024

Conversation

jakeswann1
Copy link
Contributor

Would fix #3086, if we want to break estimate_sparsity

zm711
zm711 reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. I think @alejoe91 and @samuelgarcia will decide on whether they are okay with the break. But I think it is the right idea.

@alejoe91
Copy link
Member

This is ok with me! Thanks @jakeswann1

@samuelgarcia ?

@alejoe91 alejoe91 added the core Changes to core module label Jun 28, 2024
@samuelgarcia
Copy link
Member

This is lotally OK for me.
I hope to not regret that we merge 2 weeks before the relase.
Lets see if any bombs blow up after push the merge button.

@samuelgarcia samuelgarcia merged commit 6f87a9b into SpikeInterface:main Jun 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 left review comments

@samuelgarcia samuelgarcia samuelgarcia approved these changes

Assignees
No one assigned
Labels
core Changes to core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise order of recording, sorting args
4 participants
@jakeswann1 @alejoe91 @samuelgarcia @zm711