Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bool type hint to functions in core module #3064

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Jun 21, 2024

Was waiting for a sorting to finish up so added bool type hints to core.

Couple docstring additions.

@zm711 zm711 added the documentation Improvements or additions to documentation label Jun 21, 2024
@zm711 zm711 changed the title Add bool to functions in core module Add bool type hint to functions in core module Jun 21, 2024
Copy link
Collaborator

@chrishalcrow chrishalcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@alejoe91 alejoe91 merged commit f366960 into SpikeInterface:main Jun 24, 2024
11 checks passed
@zm711 zm711 deleted the bool-magic branch June 24, 2024 10:41
@samuelgarcia
Copy link
Member

incroyable.

@zm711
Copy link
Collaborator Author

zm711 commented Jun 25, 2024

Ça, c'était le PR qu'on manquait pour le 1.0. Ça y est.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants