Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the probe handling tutorial #3063

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented Jun 21, 2024

If you do

>>> a_dict = {0: 'a', 1: 'b'}

>>> a, b = a_dict

>>>print(a)
0
>>>print(b)
1

which means people will do this wrong. I think maybe we switched the default from list to dict as some point. So I added a note in the explanation that you can choose the output and then fixed the example for the dict output instead.

@zm711 zm711 added the documentation Improvements or additions to documentation label Jun 21, 2024
Co-authored-by: Alessio Buccino <[email protected]>
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alejoe91 alejoe91 merged commit 0a45e62 into SpikeInterface:main Jun 24, 2024
11 checks passed
@zm711 zm711 deleted the fix-probe-tutorial branch June 24, 2024 10:42
@samuelgarcia
Copy link
Member

merci. This was very bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants