Improve error log to json in run_sorter #3057
Conversation
| error_log_to_display = traceback.format_exc() | ||
| trace_lines = error_log_to_display.strip().split("\n") | ||
| error_to_json = ["Traceback (most recent call last):"] + [ | ||
| f" {line}" if not line.startswith(" ") else line for line in trace_lines[1:] |
There was a problem hiding this comment.
Is the space before {line} needed?
There was a problem hiding this comment.
I don't think so. Removing it.
There was a problem hiding this comment.
Oh no sorry I understand maybe it was to keep the left-alignment the same for lines that already start with a space vs. dont? In that case can leave, or maybe just .strip() all lines?
There was a problem hiding this comment.
I feel it does not matter that much? The big gain is dividing the error trace in lines so it does not appear like a super-long-line in json I feel.
|
Nice! This looks good to me and I appreciate it after doing lots of scrolling to read those error messages. My only thoughts are (I know nothing about how these stacktraces are generated) to be sure that the line |
This is the python trace that we get from the module: https://docs.python.org/3/library/traceback.html They are meant to be displayed in a terminal so they will be divided by lines. My confidence is that it will generalize but of course can't know, we will have to wait and see. |
|
I see it is just a generic traceback that makes sense, thanks LGTM! |
| error_log_to_display = traceback.format_exc() | ||
| trace_lines = error_log_to_display.strip().split("\n") | ||
| error_to_json = ["Traceback (most recent call last):"] + [ | ||
| f" {line}" if not line.startswith(" ") else line for line in trace_lines[1:] |
There was a problem hiding this comment.
Oh no sorry I understand maybe it was to keep the left-alignment the same for lines that already start with a space vs. dont? In that case can leave, or maybe just .strip() all lines?
alejoe91
changed the title
|
merci. |
As in the title.
In the current PR:
{ "sorter_name": "kilosort3", "sorter_version": "compiled", "datetime": "2024-06-20T19:08:55.934035", "runtime_trace": [ "Warning: X does not support locale C.UTF-8", "Time 0s. Computing whitening matrix..", "Getting channel whitening matrix...", "Channel-whitening matrix computed.", "Time 2s. Loading raw data and applying filters...", "Time 2s. Finished preprocessing 4 batches.", "Drift correction ENABLED", "vertical pitch size is 20", "horizontal pitch size is 20", "0 10 20", "", "6", "", "----------------------------------------Index in position 1 exceeds array bounds. Index must not exceed 4." ], "error": true, "error_trace": [ "Traceback (most recent call last):", " File \"/root/.local/lib/python3.9/site-packages/spikeinterface/sorters/basesorter.py\", line 257, in run_from_folder", " SorterClass._run_from_folder(sorter_output_folder, sorter_params, verbose)", " File \"/root/.local/lib/python3.9/site-packages/spikeinterface/sorters/external/kilosortbase.py\", line 217, in _run_from_folder", " raise Exception(f\"{cls.sorter_name} returned a non-zero exit code\")", " Exception: kilosort3 returned a non-zero exit code" ], "run_time": null }Vs what is on main:
{ "sorter_name": "kilosort3", "sorter_version": "compiled", "datetime": "2024-06-20T19:16:49.436576", "runtime_trace": [ "Warning: X does not support locale C.UTF-8", "Time 0s. Computing whitening matrix..", "Getting channel whitening matrix...", "Channel-whitening matrix computed.", "Time 2s. Loading raw data and applying filters...", "Time 2s. Finished preprocessing 4 batches.", "Drift correction ENABLED", "vertical pitch size is 20", "horizontal pitch size is 20", "0 10 20", "", "6", "", "----------------------------------------Index in position 1 exceeds array bounds. Index must not exceed 4." ], "error": true, "error_trace": "Traceback (most recent call last):\n File \"/root/.local/lib/python3.9/site-packages/spikeinterface/sorters/basesorter.py\", line 257, in run_from_folder\n SorterClass._run_from_folder(sorter_output_folder, sorter_params, verbose)\n File \"/root/.local/lib/python3.9/site-packages/spikeinterface/sorters/external/kilosortbase.py\", line 217, in _run_from_folder\n raise Exception(f\"{cls.sorter_name} returned a non-zero exit code\")\nException: kilosort3 returned a non-zero exit code\n", "run_time": null }